tree 7c041d9ee46379b51d7f9cba13f78b78161337fc
parent 4bd1920723d7b7c925de087aa32e2187708897f7
author lmilewski <lmilewski@google.com> 1478283705 +0000
committer Joe Tsai <joetsai@digital-static.net> 1479171568 -0800

proto: generate Get methods for fields of basic type in proto3

Given proto3 schema:

  message Foo {
    string some_value = 1;
  }

  message Bar {
    Foo foo = 1;
  }

  message Baz {
    Bar bar = 1;
  }

Accessing baz.bar.foo.SomeValue currently requires this code:

        if f := baz.GetBar().GetFoo(); f != nil {
                fmt.Printf("value was %v\n", f.SomeValue)
        }

After the CL, it becomes:

        fmt.Printf("value was %v\n", baz.GetBar().GetFoo().GetSomeValue())

There are downsides to generating more code:
   - all things equal, less code is better
   - larger API surface

The upsides are:
 - consistency with proto2 API (proto2 and proto3 can be mixed. Keeping API consistent is important)
 - easier to explain API - all fields have Get method. No exceptions.
 - reduced user confusion - questions about this come up frequently

testing:
  - added a new test
  - inspected a diff for an arbitrarily chosen schema
PiperOrigin-RevId: 138212965