tree 8ce7d8a6597f99d5f72cf0a0071673b2c21d6f01
parent 20500e2abd0d1f4564a499e83d11d6c73cd58c27
author Jamie Wilkinson <jaq@spacepants.org> 1474318874 +1000
committer Bjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com> 1474318874 +0200

Fixes a pass-by-value error in FileData.Name()

Fixes a pass-by-value error in FileData.Name() which causes the mutex to be copied, and use that method to retrieve the name of the file from a mem.File.  This really fixes the data race that motivated PR #95. (#96)

I can't explain why moving the lock improves the situation, nor why calling through the accessor Name() instead of locking and reading f.fileData.name is not the same, but go vet indicates that the mutex in fileData was being copied, not preserved.

The reproducing test case upstream is:
check out github.com/google/mtail
make install_deps
go test -race -timeout 1m -v -run TestProcessEvents --count=10000 ./vm

Prior to this change, the test reports a data race 3 times out of 10000, after, 0 times consistently.