Merge pull request #162 from stevvooe/timestamp-layout
Allow configuration of timestamp layout
diff --git a/formatter.go b/formatter.go
index 038ce9f..104d689 100644
--- a/formatter.go
+++ b/formatter.go
@@ -1,5 +1,9 @@
package logrus
+import "time"
+
+const DefaultTimestampFormat = time.RFC3339
+
// The Formatter interface is used to implement a custom Formatter. It takes an
// `Entry`. It exposes all the fields, including the default ones:
//
diff --git a/formatters/logstash/logstash.go b/formatters/logstash/logstash.go
index 34b1ccb..8ea93dd 100644
--- a/formatters/logstash/logstash.go
+++ b/formatters/logstash/logstash.go
@@ -3,19 +3,27 @@
import (
"encoding/json"
"fmt"
+
"github.com/Sirupsen/logrus"
- "time"
)
// Formatter generates json in logstash format.
// Logstash site: http://logstash.net/
type LogstashFormatter struct {
Type string // if not empty use for logstash type field.
+
+ // TimestampFormat sets the format used for timestamps.
+ TimestampFormat string
}
func (f *LogstashFormatter) Format(entry *logrus.Entry) ([]byte, error) {
entry.Data["@version"] = 1
- entry.Data["@timestamp"] = entry.Time.Format(time.RFC3339)
+
+ if f.TimestampFormat == "" {
+ f.TimestampFormat = logrus.DefaultTimestampFormat
+ }
+
+ entry.Data["@timestamp"] = entry.Time.Format(f.TimestampFormat)
// set message field
v, ok := entry.Data["message"]
diff --git a/json_formatter.go b/json_formatter.go
index 5c4c44b..dcc4f1d 100644
--- a/json_formatter.go
+++ b/json_formatter.go
@@ -3,10 +3,12 @@
import (
"encoding/json"
"fmt"
- "time"
)
-type JSONFormatter struct{}
+type JSONFormatter struct {
+ // TimestampFormat sets the format used for marshaling timestamps.
+ TimestampFormat string
+}
func (f *JSONFormatter) Format(entry *Entry) ([]byte, error) {
data := make(Fields, len(entry.Data)+3)
@@ -21,7 +23,12 @@
}
}
prefixFieldClashes(data)
- data["time"] = entry.Time.Format(time.RFC3339)
+
+ if f.TimestampFormat == "" {
+ f.TimestampFormat = DefaultTimestampFormat
+ }
+
+ data["time"] = entry.Time.Format(f.TimestampFormat)
data["msg"] = entry.Message
data["level"] = entry.Level.String()
diff --git a/text_formatter.go b/text_formatter.go
index d3687ba..612417f 100644
--- a/text_formatter.go
+++ b/text_formatter.go
@@ -18,9 +18,8 @@
)
var (
- baseTimestamp time.Time
- isTerminal bool
- defaultTimestampFormat = time.RFC3339
+ baseTimestamp time.Time
+ isTerminal bool
)
func init() {
@@ -47,7 +46,7 @@
// the time passed since beginning of execution.
FullTimestamp bool
- // Timestamp format to use for display, if a full timestamp is printed
+ // TimestampFormat to use for display when a full timestamp is printed
TimestampFormat string
// The fields are sorted by default for a consistent output. For applications
@@ -73,7 +72,7 @@
isColored := (f.ForceColors || isTerminal) && !f.DisableColors
if f.TimestampFormat == "" {
- f.TimestampFormat = defaultTimestampFormat
+ f.TimestampFormat = DefaultTimestampFormat
}
if isColored {
f.printColored(b, entry, keys)